Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to enable corepack #901

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
docs: node version
  • Loading branch information
jrparish committed Nov 21, 2023
commit f9532b258e7ddfc36a3f549c77f42ea4ddc4db64
8 changes: 4 additions & 4 deletions docs/advanced-usage.md
Original file line number Diff line number Diff line change
@@ -157,7 +157,7 @@ jobs:

## Nightly versions

You can specify a nightly version to download it from https://nodejs.org/download/nightly.
You can specify a nightly version to download it from https://nodejs.org/download/nightly.

### Install the nightly build for a major version

@@ -265,7 +265,7 @@ steps:
- run: pnpm test
```

> **Note**: By default `--frozen-lockfile` option is passed starting from pnpm `6.10.x`. It will be automatically added if you run it on [CI](https://pnpm.io/cli/install#--frozen-lockfile).
> **Note**: By default `--frozen-lockfile` option is passed starting from pnpm `6.10.x`. It will be automatically added if you run it on [CI](https://pnpm.io/cli/install#--frozen-lockfile).
> If the `pnpm-lock.yaml` file changes then pass `--frozen-lockfile` option.


@@ -425,7 +425,7 @@ steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
corepack: true

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the input corepack is not listed in /action.yml
did you forget to add it there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- name: Install dependencies
run: yarn install --immutable
@@ -438,7 +438,7 @@ steps:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16.x'
node-version: '18.x'
corepack: yarn pnpm
- name: Install dependencies
run: yarn install --immutable