-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make eslint-compact matcher compatible with Stylelint #98
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I really want this update! 🙏 |
any interest in updating PR to target main instead of master? |
@bryanmacfarlane Done 👌 |
|
[Fix] Creating sandbox from recipe with CPCode is not using provided CPCode
Friendly ping 🏓 |
Stylelint has a
compact
formatter that is (nearly) compatible with ESLint one's.It outputs lowercase severity strings though, so
eslint-compact
matcher's RegExp is not triggered.This PR changes the matcher to also match lowercase severity strings.
Alternatively, the matcher could be duplicated as
stylelint-compact
and both RegExps could target exact lowercase/uppercase severities.Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295