Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make eslint-compact matcher compatible with Stylelint #98

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FloEdelmann
Copy link

@FloEdelmann FloEdelmann commented Dec 27, 2019

Stylelint has a compact formatter that is (nearly) compatible with ESLint one's.

It outputs lowercase severity strings though, so eslint-compact matcher's RegExp is not triggered.

This PR changes the matcher to also match lowercase severity strings.

Alternatively, the matcher could be duplicated as stylelint-compact and both RegExps could target exact lowercase/uppercase severities.


Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295

Copy link

@ViniciusFXavier ViniciusFXavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ybiquitous
Copy link

I really want this update! 🙏

@bryanmacfarlane
Copy link
Member

any interest in updating PR to target main instead of master?

@FloEdelmann FloEdelmann changed the base branch from master to main January 20, 2021 19:48
@FloEdelmann
Copy link
Author

@bryanmacfarlane Done 👌

@FloEdelmann FloEdelmann requested a review from a team August 15, 2022 08:36
@Jimimaku
Copy link

Stylelint has a compact formatter that is (nearly) compatible with ESLint one's.

It outputs lowercase severity strings though, so eslint-compact matcher's RegExp is not triggered.

This PR changes the matcher to also match lowercase severity strings.

Alternatively, the matcher could be duplicated as stylelint-compact and both RegExps could target exact lowercase/uppercase severities.

Example check run containing Stylelint output: https://github.com/OpenLightingProject/open-fixture-library/pull/1163/checks?check_run_id=365592295

krzyk pushed a commit to krzyk/setup-node that referenced this pull request Apr 11, 2023
[Fix] Creating sandbox from recipe with CPCode is not using provided CPCode
@szepeviktor
Copy link

Friendly ping 🏓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants