do not attempt to delete existing cache #1183
Closed
+5
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It introduces a TOCTOU issue, and is not needed because `restoreCache` returns `undefined` if the cache does not exist https://github.com/actions/toolkit/tree/main/packages/cache
This was referenced Oct 17, 2024
|
CI results available in https://github.com/ericLemanissier/stale/pull/21/checks |
|
@suyashgaonkar what do you think of this change ? |
|
@aparnajyothi-y @suyashgaonkar what to you think of this change ? |
|
well, it looks like caches are actually immutable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I don't think it's necessary to delete existing cache before overwriting it. https://github.com/actions/cache does not seem to do it. The problem with deleting a cache entry is that it requires to give
actions: writepermissions, which means the workflow has all these permissions and this is way too much, and not acceptable for a lot of projects.Also, do not check if cache exists during restore. It introduces a TOCTOU issue, and is not needed because
restoreCachereturnsundefinedif the cache does not exist, cf https://github.com/actions/toolkit/tree/main/packages/cacheRelated issue:
fixes #1159
fixes #1133
fixes #1131
Check list: