-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generator-generic-ossf-slsa3-publish.yml to v2.1.0 #2788
Open
ramonpetgrave64
wants to merge
1
commit into
actions:main
Choose a base branch
from
ramonpetgrave64:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottBrenner
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't @dependabot be bumping these? https://github.com/actions/starter-workflows/blob/main/.github/dependabot.yml
Scott Brenner is the *author of three books: Worship Encounter, The
Heartbeat of Worship and The Lamb's Revolution*. Scott is also a well-known
worship leader, songwriter and producer.
…On Wed, Feb 26, 2025 at 12:30 PM Ramon Petgrave ***@***.***> wrote:
Pre-requisites
- Prior to submitting a new workflow, please apply to join the GitHub
Technology Partner Program: partner.github.com/apply
<https://partner.github.com/apply?partnershipType=Technology+Partner>.
------------------------------
*Please note that at this time we are only accepting new starter workflows
for Code Scanning. Updates to existing starter workflows are fine.*
------------------------------
Tasks
*For all workflows, the workflow:*
- Should be contained in a .yml file with the language or platform as
its filename, in lower, *kebab-cased*
<https://en.wikipedia.org/wiki/Kebab_case> format (for example,
docker-image.yml
<https://github.com/actions/starter-workflows/blob/main/ci/docker-image.yml>).
Special characters should be removed or replaced with words as appropriate
(for example, "dotnet" instead of ".NET").
- Should use sentence case for the names of workflows and steps (for
example, "Run tests").
- Should be named *only* by the name of the language or platform (for
example, "Go", not "Go CI" or "Go Build").
- Should include comments in the workflow for any parts that are not
obvious or could use clarification.
- Should specify least privileged permissions
<https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token>
for GITHUB_TOKEN so that the workflow runs successfully.
*For CI workflows, the workflow:*
- Should be preserved under the ci directory
<https://github.com/actions/starter-workflows/tree/main/ci>.
- Should include a matching ci/properties/*.properties.json file (for
example, ci/properties/docker-publish.properties.json
<https://github.com/actions/starter-workflows/blob/main/ci/properties/docker-publish.properties.json>
).
- Should run on push to branches: [ $default-branch ] and pull_request
to branches: [ $default-branch ].
- Packaging workflows should run on release with types: [ created ].
- Publishing workflows should have a filename that is the name of the
language or platform, in lower case, followed by "-publish" (for example,
docker-publish.yml
<https://github.com/actions/starter-workflows/blob/main/ci/docker-publish.yml>
).
*For Code Scanning workflows, the workflow:*
- Should be preserved under the code-scanning directory
<https://github.com/actions/starter-workflows/tree/main/code-scanning>.
- Should include a matching code-scanning/properties/*.properties.json
file (for example, code-scanning/properties/codeql.properties.json
<https://github.com/actions/starter-workflows/blob/main/code-scanning/properties/codeql.properties.json>),
with properties set as follows:
- name: Name of the Code Scanning integration.
- creator: Name of the organization/user producing the Code
Scanning integration.
- description: Short description of the Code Scanning integration.
- categories: Array of languages supported by the Code Scanning
integration.
- iconName: Name of the SVG logo representing the Code Scanning
integration. This SVG logo must be present in the icons directory
<https://github.com/actions/starter-workflows/tree/main/icons>.
- Should run on push to branches: [ $default-branch,
$protected-branches ] and pull_request to branches: [ $default-branch ].
We also recommend a schedule trigger of cron: $cron-weekly (for
example, codeql.yml
<https://github.com/actions/starter-workflows/blob/c59b62dee0eae1f9f368b7011cf05c2fc42cf084/code-scanning/codeql.yml#L14-L21>
).
*Some general notes:*
- This workflow must *only* use actions that are produced by GitHub, in
the actions organization <https://github.com/actions>, *or*
- This workflow must *only* use actions that are produced by the
language or ecosystem that the workflow supports. These actions must be published
to the GitHub Marketplace <https://github.com/marketplace?type=actions>.
We require that these actions be referenced using the full 40 character
hash of the action's commit instead of a tag. Additionally, workflows must
include the following comment at the top of the workflow file:
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.
- Automation and CI workflows should not send data to any 3rd party
service except for the purposes of installing dependencies.
- Automation and CI workflows cannot be dependent on a paid service or
product.
------------------------------
You can view, comment on, or merge this pull request online at:
#2788
Commit Summary
- 4db1828
<4db1828>
Update generator-generic-ossf-slsa3-publish.yml to v2.1.0
File Changes
(1 file <https://github.com/actions/starter-workflows/pull/2788/files>)
- *M* ci/generator-generic-ossf-slsa3-publish.yml
<https://github.com/actions/starter-workflows/pull/2788/files#diff-d04c69a2b50786da6b14429722bd87221805a77db7751595c34f56025d8a2e27>
(2)
Patch Links:
- https://github.com/actions/starter-workflows/pull/2788.patch
- https://github.com/actions/starter-workflows/pull/2788.diff
—
Reply to this email directly, view it on GitHub
<#2788>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBSDRJEPSI3L67JOXXNLAD32RX23RAVCNFSM6AAAAABX5ZXHDOVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA4DEMZSGQ2TINQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2377
Pre-requisites
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
.yml
file with the language or platform as its filename, in lower, kebab-cased format (for example,docker-image.yml
). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").GITHUB_TOKEN
so that the workflow runs successfully.For CI workflows, the workflow:
ci
directory.ci/properties/*.properties.json
file (for example,ci/properties/docker-publish.properties.json
).push
tobranches: [ $default-branch ]
andpull_request
tobranches: [ $default-branch ]
.release
withtypes: [ created ]
.docker-publish.yml
).For Code Scanning workflows, the workflow:
code-scanning
directory.code-scanning/properties/*.properties.json
file (for example,code-scanning/properties/codeql.properties.json
), with properties set as follows:name
: Name of the Code Scanning integration.creator
: Name of the organization/user producing the Code Scanning integration.description
: Short description of the Code Scanning integration.categories
: Array of languages supported by the Code Scanning integration.iconName
: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in theicons
directory.push
tobranches: [ $default-branch, $protected-branches ]
andpull_request
tobranches: [ $default-branch ]
. We also recommend aschedule
trigger ofcron: $cron-weekly
(for example,codeql.yml
).Some general notes:
actions
organization, or