feat(cache): support passing extra tar args #1699
Open
+39
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robherley, @bethanyj28, please review |
|
As a user of |
|
+1 this would allow a targeted workaround for issue #1753 |
|
@robherley @Link- please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usecase
In
cache-nix-action, I exclude some files when restoring a cache (link).Security
IDK if this change can introduce potential vulnerabilities.
TODO
Insert arguments in the correct places. Some arguments of
create,list, andextractare positional. Hence, extra arguments should be inserted into right places when invoking these commands. E.g., before '--files-from' in 'create'toolkit/packages/cache/src/internal/tar.ts
Line 86 in 8780507
Other PRs about tar