set workflow.ref provenance field from ref claim #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the `buildSLSAProvenancePredicate` function to populate the `workflow.ref` field from the `ref` claim in the OIDC token. Signed-off-by: Brian DeHamer <bdehamer@github.com>
bdehamer
force-pushed
the
bdehamer/workflow-ref
branch
from
c59c9d5 to
0bc338a
Compare
bdehamer
commented
Feb 26, 2025
Comment on lines
-78
to
-87
|
|
||
| it('handle tags including "@" character', async () => { | ||
| nock.cleanAll() | ||
| await mockIssuer({ | ||
| ...claims, | ||
| workflow_ref: 'owner/repo/.github/workflows/main.yml@foo@1.0.0' | ||
| }) | ||
| const predicate = await buildSLSAProvenancePredicate() | ||
| expect(predicate).toMatchSnapshot() | ||
| }) |
There was a problem hiding this comment.
This test was specifically handling the scenario where the ref was parsed from the workflow_ref claim and is no longer necessary since we no longer need to extract this value.
This was referenced Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
buildSLSAProvenancePredicatefunction in the@actions/attestpackage to populate theworkflow.reffield from therefclaim in the OIDC token.For most events which trigger a workflow run (
push,release,workflow_dispatch, etc) this will have no impact on generated predicate statement. For other events which may be triggered from ref-less commits, this will ensure that the populated value more accurately reflects the state of the workflow run.