Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated action #1018

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

kevin-belellou
Copy link
Contributor

Action github/setup-licensed has been deprecated since February 7 2025 in favor of licensee/setup-licensed

@kevin-belellou kevin-belellou requested a review from a team as a code owner February 15, 2025 15:23
@kevin-belellou
Copy link
Contributor Author

I would have preferred to keep the v1 tag but it does not exist in the new repository.
But I have opened an issue with them, so maybe you want to wait for it to be resolved before merging this PR.

@ncalteen ncalteen self-assigned this Feb 27, 2025
@ncalteen
Copy link
Collaborator

Looks like the maintainers of that action haven't responded yet. Thankfully Dependabot is configured on this template, so updates to the action version should be handled automatically when new releases are published. For now, I think it is better to move forward on this and get off of the deprecated action.

Thank you for the contribution! Out of curiosity, would you be willing to open PRs to update this in the following repos as well? That way I can review them and get them updated too.

@ncalteen ncalteen merged commit ae57643 into actions:main Feb 27, 2025
6 checks passed
@kevin-belellou kevin-belellou deleted the replace-deprecated-action branch March 1, 2025 12:55
@kevin-belellou
Copy link
Contributor Author

@ncalteen You're welcome for the contribution!

I opened equivalent PRs in actions/hello-world-javascript-action and actions/container-toolkit-action.
For the third repo, actions/javascript-action, you seems to have already made the change (maybe by error) when porting your Fix reference commit from actions/typescript-action to actions/javascript-action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants