WIP: Add Adafruit Metro RP2350 16MB No PSRAM #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @dhalbert can you have a quick gander here and offer some advice please. I've updated all the values using the feather rp2350 as a base, and scraping B related values from other variants.
For now the commented chunks with different title format are from arduino definitions for reference, I'll clean this up before un-drafting the PR.
Should the name of the board include nopsram, and possibly the 16mb flash size? I saw some boards defined a couple of names so I have temporarily offered suggestions in that way too.
I see there is a PSRAM CS pin defined for arduino, (I'm aware this has an unpopulated footprint) so should I define one too?
https://github.com/earlephilhower/arduino-pico/blob/master/variants/adafruit_metro_rp2350/pins_arduino.h#L67-L70
I also didn't spot any of our boards defining the boot button, except a macropad version using an approximation of the board name, so advice there would be appreciated too.
Then there's the SPI clock frequency divisor (2 on feather rp2350 and 4 on other board), where would that be in arduino land, or another way of finding / calculating it?
Finally the DVI connector / hstx connector seems absent from the feather definition, along with the USB port for the feather_rp2040_usb_host so I'm not quite sure what's expected there and for dvi connector etc, or where those pins get specified (presumably just default gpio number based automatic definitions). I wouldn't worry except there's a 5volt enable pin and related defines in arduino land so I wonder if needed here too:
https://github.com/earlephilhower/arduino-pico/blob/master/variants/adafruit_metro_rp2350/pins_arduino.h#L13-L17
and https://github.com/earlephilhower/arduino-pico/blob/master/variants/adafruit_metro_rp2350/pins_arduino.h#L71-L79