feat(recommend): add Trending-Facets model #6556
Conversation
raed667
requested review from
marialungu,
dhayab,
sarahdayan and
aymeric-giraudet
and removed request for
marialungu
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9fb4690:
|
raed667
force-pushed
the
feat/recommend/trending-facets
branch
from
c0c390d to
6e760d8
Compare
raed667
force-pushed
the
feat/recommend/trending-facets
branch
from
6e760d8 to
bc997e5
Compare
|
@algolia/frontend-experiences-web hi team, this is not urgent, but can someone help figure out go the fix the V4 types 🙏 ? |
| @@ -0,0 +1,6 @@ | |||
| import type { TrendingFacetHit as Base } from 'algoliasearch/lite'; | |||
There was a problem hiding this comment.
you'll want to import this in the algoliasearch.d.ts file in the helper and correctly ts-ignore, and pass the relevant type of v3 (any?), v4 and v5
raed667
force-pushed
the
feat/recommend/trending-facets
branch
2 times, most recently
from
c077e94 to
c02fee6
Compare
| @@ -19,7 +19,7 @@ import type { | |||
| Renderer, | |||
| SendEventForHits, | |||
| } from '../types'; | |||
| import type { TrendingFacetHit as Base } from 'algoliasearch/lite'; | |||
| import type { TrendingFacetHit as Base } from 'instantsearch.js'; | |||
There was a problem hiding this comment.
you should import from ../types
raed667
force-pushed
the
feat/recommend/trending-facets
branch
from
c02fee6 to
9137cc8
Compare
| Renderer, | ||
| SendEventForHits, | ||
| } from '../types'; | ||
| import type { TrendingFacetHit } from 'algoliasearch'; |
There was a problem hiding this comment.
this should also be in the helper or just retyped { objectID: string, facetValue: string}?
raed667
force-pushed
the
feat/recommend/trending-facets
branch
2 times, most recently
from
cb6e6d3 to
2806db3
Compare
raed667
force-pushed
the
feat/recommend/trending-facets
branch
from
2806db3 to
be5ab5c
Compare
|
Originally we didn't implement trending facets as it's not clear how we want to incorporate the filtering / links inside it, as it could be many different attributes, refinement types. However, it makes sense to be able to fully deprecate the old recommend widgets, and so we'll need trending facets too. What we'll need to be able to later create a filtering directly from this widget I think is to make the itemComponent required here, so changing the default isn't a breaking change. |
Summary
Add Recommend model
trending-facetsTODO
sendEvent(Recommend analytics does not supporttrending-facets)