-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: toggle refinement styling #6596
base: feat/algoliacss
Are you sure you want to change the base?
feat: toggle refinement styling #6596
Conversation
thomasbritton
commented
Feb 28, 2025
(cherry picked from commit 11709a6)
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a24815:
|
font-size: 0.875rem; | ||
line-height: 1.75rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to add this? I think we don't need to be opinionated here.
.ais-ToggleRefinement-label { | ||
font-size: 0.875rem; | ||
line-height: 1.75rem; | ||
display: block; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
display: block; |
This is overridden in l. 9.
display: flex; | ||
} | ||
|
||
input[class^='ais-'][class*='ToggleRefinement-checkbox'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we need such selector, why not target .ais-ToggleRefinement-checkbox
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because there is a selector in common.css
that is of higher specificity input[class^='ais-'][type='checkbox']:checked { /* ... */ }
I did it this way because we were out of time so just needed something quick that would work but the class above probably needs to be merged into the refinement-list.css