Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review will not fail automatically in case of issues #47

Open
headless-kjh opened this issue Mar 20, 2023 · 4 comments
Open

Code review will not fail automatically in case of issues #47

headless-kjh opened this issue Mar 20, 2023 · 4 comments

Comments

@headless-kjh
Copy link

headless-kjh commented Mar 20, 2023

image

For some reason, there was an issue with the review
and action didn't cancel until the 6-hour timeout had elapsed

@@ -6,6 +6,7 @@
import lombok.Getter;

import java.math.BigDecimal;
import java.math.RoundingMode;

@Getter
@Builder(access = AccessLevel.PRIVATE)
@@ -21,6 +22,8 @@ public class SubscriptionPlanDto {
    public static SubscriptionPlanDto NONE() {
        // TODO: 구독 없는 경우 어떻게 처리? (플로우)
        return SubscriptionPlanDto.builder()
                .planCode("")
                .price(BigDecimal.ZERO)
                .name("이용중인 서비스 없음")
                .isActive(false)
                .build();
@@ -34,7 +37,7 @@ public static SubscriptionPlanDto of(SubscriptionPlan plan) {
                .description(plan.getDescription())
                .planCode(plan.getPlanCode())
                .price(plan.getPrice())
                .priceIncludeVat(plan.getPrice().multiply(BigDecimal.valueOf(1.1)))
                .priceIncludeVat(plan.getPrice().multiply(BigDecimal.valueOf(1.1)).setScale(0, RoundingMode.FLOOR)) // 1원단위 절삭
                .isActive(plan.getIsActive())
                .build();
    }

This code that tried, just simple

@anc95
Copy link
Owner

anc95 commented Mar 20, 2023

@headless-kjh Actually I have no idea what causes this. could you help to re-run the job, let's check if it doesn't exit for the PR every time

@headless-kjh
Copy link
Author

I think the focus should be on the fact that the function does not terminate when a problem occurs, rather than on the cause of the problem itself.
No errors occurred during the "re-run".

@LukeSamkharadze
Copy link

OpenAI has really bad uptime, that could be the issue.

Are we sure this is being handled correctly?

https://status.openai.com

@headless-kjh
Copy link
Author

We have the same error again today. It's not a special case. It seems that failure timeout or retry is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants