Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request(GitHub App): Specify label name to be reviewed in .env #76

Open
HosakaKeigo opened this issue Apr 28, 2023 · 2 comments

Comments

@HosakaKeigo
Copy link
Contributor

HosakaKeigo commented Apr 28, 2023

Purpose

As per Github Actions version, it would be convenient if you can specify the label name to be reviewed in GitHub App version.

Suggestion

Here's my implementation suggestion.

      const target_label = process.env.TARGET_LABEL
      if (target_label && pull_request.labels.every(label => label.name !== target_label)) {
        return "no target label attached"
      }

I also tried to make a PR, but npm test doesn't work for my environment. (Windows / WSL2)

@anc95
Copy link
Owner

anc95 commented Apr 28, 2023

@HosakaKeigo sorry for the test is not workable yet. Could you help to create a pull request of beyond code, it looks fine to me.

@HosakaKeigo
Copy link
Contributor Author

@anc95
Thank you for your reply! I made a PR for this issue. Hope it helps.
#77

codehome0301 added a commit to codehome0301/ChatGPT-CodeReview that referenced this issue Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants