Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't not build Docker image directly #80

Closed
PeterDaveHello opened this issue May 4, 2023 · 0 comments · Fixed by #81
Closed

Can't not build Docker image directly #80

PeterDaveHello opened this issue May 4, 2023 · 0 comments · Fixed by #81

Comments

@PeterDaveHello
Copy link
Contributor

PeterDaveHello commented May 4, 2023 •
edited
Loading

Looks like package-lock.json is missing, or should we switch to yarn in Dockerfile, as there is yarn.lock file?

~/ChatGPT-CodeReview $ docker build -t before .
Sending build context to Docker daemon  17.38MB
Step 1/8 : FROM node:18-slim
18-slim: Pulling from library/node
9e3ea8720c6d: Pull complete 
22cee24855b2: Pull complete 
1f1858138a90: Pull complete 
6e736ef1cbb5: Pull complete 
c4ef7605ff4f: Pull complete 
Digest: sha256:2ff9841de879f1a2d2d8ef83183c2d93435c451a36d6cfb37b3331d1386c00f8
Status: Downloaded newer image for node:18-slim
 ---> 249e97c8a29e
Step 2/8 : WORKDIR /usr/src/app
 ---> Running in eb421e4594e0
Removing intermediate container eb421e4594e0
 ---> d958cab7c813
Step 3/8 : COPY package.json package-lock.json ./
COPY failed: file not found in build context or excluded by .dockerignore: stat package-lock.json: file does not exist
PeterDaveHello added a commit to PeterDaveHello/ChatGPT-CodeReview that referenced this issue May 4, 2023
@PeterDaveHello
Use yarn instead of npm in Dockerfile, fix anc95#80
74f4a79
@PeterDaveHello PeterDaveHello mentioned this issue May 4, 2023
Merged
@anc95 anc95 closed this as completed in #81 May 5, 2023
anc95 pushed a commit that referenced this issue May 5, 2023
@PeterDaveHello
Use yarn instead of npm in Dockerfile, fix #80 (#81)
3140308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use yarn instead of npm in Dockerfile PeterDaveHello/ChatGPT-CodeReview
1 participant
@PeterDaveHello