Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not fill in the Level field of the SARIF result object #2511

Open
bdovaz opened this issue Mar 6, 2025 · 2 comments
Open

Does not fill in the Level field of the SARIF result object #2511

bdovaz opened this issue Mar 6, 2025 · 2 comments
Labels
bug Something isn't working good-first-issue Good for newcomers

Comments

@bdovaz
Copy link

bdovaz commented Mar 6, 2025

As you can see it does not fill the level field of the result object:

func (p Presenter) sarifResults() []*sarif.Result {

This causes that according to the sarif specification, the level value is warning: https://json.schemastore.org/sarif-2.1.0.json

Image

@bdovaz bdovaz added the bug Something isn't working label Mar 6, 2025
@kzantow kzantow added the good-first-issue Good for newcomers label Mar 7, 2025
@kzantow kzantow moved this to Ready in OSS Mar 7, 2025
@kzantow
Copy link
Contributor

kzantow commented Mar 7, 2025

This sounds like a good improvement @bdovaz! I think we would probably want to populate this level using logic similar to how the securitySeverity is determined, would you agree?

@bdovaz
Copy link
Author

bdovaz commented Mar 7, 2025

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good-first-issue Good for newcomers
Projects
Status: Ready
Development

No branches or pull requests

2 participants