Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: preview #85

Closed
wants to merge 1 commit into from
Closed

test: preview #85

wants to merge 1 commit into from

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Nov 7, 2020

I'm doing a test and will close a little bit.

@github-actions
Copy link

github-actions bot commented Nov 7, 2020

🎊 PR Preview 256863e has been successfully built and deployed to https://antvis-antvis-github-io-preview-pr-85.surge.sh

🕐 Build time: 274.21s

🤖 By surge-preview

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 7, 2020

@afc163 @kerm1it 这好像没预览成功呢

我试了几个都不行,预览界面还保持原状

ant-design/pro-components#923
zoo-js/zoo-issue-helper#51
ant-design-colorful/ant-design-colorful#18

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 7, 2020

我用法不对?

@afc163
Copy link
Contributor

afc163 commented Nov 9, 2020

@xrkffgg 貌似确实有问题,pull_request_target 指向了原始分支。

cc @shaodahong

@shaodahong
Copy link

一个已知的问题,actions/checkout#321

对于 PR 来说可以尝试这个方案
https://github.com/actions/checkout/blob/f16eddee8410930a20309c41063631c4177643a5/README.md#checkout-pull-request-on-pull_request_target

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 9, 2020

zoo-js/zoo-issue-helper#54

加上这个可以了

with:
ref: refs/pull/${{ github.event.pull_request.number }}/merge

@xrkffgg xrkffgg mentioned this pull request Nov 9, 2020
@afc163
Copy link
Contributor

afc163 commented Nov 9, 2020

能在 surge_preview 里解决么?不然又要发一堆 PR 了:

ant-design/ant-design#27453

image

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 9, 2020

感觉不需用 push 触发啊

image

@shaodahong
Copy link

应该不行,还没到 surge_preview 这一步,其他的仓库暂时先不动,改这个库试试,后续没问题我来提 PR 吧

@xrkffgg
Copy link
Member Author

xrkffgg commented Nov 9, 2020

push 检测了 build 正常,生成不了 url 来预览呢

@xrkffgg xrkffgg closed this Nov 9, 2020
@xrkffgg xrkffgg deleted the patch-1 branch November 9, 2020 10:07
afc163 added a commit to antvis/gatsby-theme-antv that referenced this pull request Nov 10, 2020
afc163 added a commit to antvis/G2Plot that referenced this pull request Nov 11, 2020
修复部署了原始分支而不是 PR 所在分支的问题。

antvis/antvis.github.io#85 (comment)
hustcc pushed a commit to antvis/G2Plot that referenced this pull request Nov 11, 2020
修复部署了原始分支而不是 PR 所在分支的问题。

antvis/antvis.github.io#85 (comment)
jinhuiWong pushed a commit to jinhuiWong/G2Plot that referenced this pull request Nov 15, 2020
修复部署了原始分支而不是 PR 所在分支的问题。

antvis/antvis.github.io#85 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants