Update MongoDB driver to mongodb-driver-legacy:5.3.1 #34100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyemin
changed the title
jyemin
commented
Feb 27, 2025
| @@ -839,7 +839,7 @@ class BeamModulePlugin implements Plugin<Project> { | |||
| log4j2_slf4j_impl : "org.apache.logging.log4j:log4j-slf4j-impl:$log4j2_version", | |||
| mockito_core : "org.mockito:mockito-core:3.7.7", | |||
| mockito_inline : "org.mockito:mockito-inline:4.5.1", | |||
| mongo_java_driver : "org.mongodb:mongo-java-driver:3.12.11", | |||
| mongo_java_driver : "org.mongodb:mongodb-driver-legacy:5.3.1", | |||
There was a problem hiding this comment.
To minimize the changes, I left the name of the library as is, but happy to change it to mongodb-driver-legacy if that makes sense.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
jyemin
commented
Feb 27, 2025
| @@ -380,7 +380,7 @@ protected static class BoundedGridFSSource extends BoundedSource<ObjectId> { | |||
|
|
|||
| private DBCursor createCursor(GridFS gridfs) { | |||
| if (spec.filter() != null) { | |||
| DBObject query = (DBObject) JSON.parse(spec.filter()); | |||
| DBObject query = BasicDBObject.parse(spec.filter()); | |||
There was a problem hiding this comment.
The Extended JSON syntax accepted by BasicDBObject#parse is mostly consistent with the syntax accepted by JSON#parse. To understand whether this might cause compatibility issues, can anyone point me to how spec.filter() is initialized? Does the filter come from the application or is it generated by the framework, and if the later, where in the code does that happen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade MongoDB Driver to latest available release.
Note that as of 4.0 the mongo-java-driver uber jar is no longer published, so using mongodb-driver-legacy (which will pull in transitive dependencies) in its place.
I'll also note that I wasn't able to build the project locally without errors so I'm using the PR to check whether everything still works.
#32088
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.