[Prism] Refactor stageState to a behavior interface to reduce branch combinatorics #34132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic no-behavior change refactoring to split the different stage kinds up more cleanly into the 3 types: ordinary, Stateful, and aggregation.
While their differences don't come up everywhere, they in particular affect when building bundles, and adding pending input elements to their stages.
The hope of this change is to reduce the combinatorics complexity parts of prism were suffering under, depending on which kind of stage was being handled. This leads to some duplication between Stateful and aggregation stages, but having clear handling of their differences should make up for it.
This is a minimal change. Not every potential portion is moved over right now, just those that had additional branching paths due to the old Stateful or aggregate booleans. Future changes should move handling of the pending elements stacks into similar methods instead of simply checking both.
Part of prism work: #29650 and was originally mentioned in #33881
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.