Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker dev environment set up #34142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

charlespnh
Copy link

Please add a meaningful description for your change here

I was setting up the dev environment using Docker and came across these errors...

  1. python12-disutils not found - From https://docs.python.org/3.10/whatsnew/3.10.html#distutils-deprecated, it looks like distutils is deprecated and removed in python 3.12 in place of setuptools which we already installed with python3-setuptools.
  2. NullPointerException when running task :sdks:java:core:compileJava - From the Docker image I was using Java 8 and got this NPE error. If I used Java 11, it was fine. Based on the contributor-docs/code-change-guide.md, Java 11 is preferrable but in the CONTRIBUTING.md Java 8 is still being recommended...

beam-docker-dev-error


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@charlespnh charlespnh marked this pull request as ready for review March 2, 2025 22:12
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@liferoad
Copy link
Contributor

liferoad commented Mar 2, 2025

Thanks for checking this. We do not support Python 3.6 now. So porably we can update https://github.com/apache/beam/blob/master/dev-support/docker/Dockerfile#L65. The java8 error is strange, which probably means java8 is not installed correctly.

@charlespnh
Copy link
Author

charlespnh commented Mar 3, 2025

I'll see if I can reproduce this java 8 error with a github action... I didn't manually install these dependencies so kinda hard to believe that java 8 was not installed correctly for me...

@charlespnh
Copy link
Author

We do not support Python 3.6 now. So porably we can update https://github.com/apache/beam/blob/master/dev-support/docker/Dockerfile#L65.

Removed.

The java8 error is strange, which probably means java8 is not installed correctly.

I'm reproducing the issue here: https://github.com/charlespnh/beam/actions/runs/13744591726?pr=1. Not sure how to fix this with the cryptic error messages... But I guess we're using Java 11 anyway for development (contributor-docs/code-change-guide.md)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants