Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alloy language connector #34156

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Conversation

claudevdm
Copy link
Collaborator

@claudevdm claudevdm commented Mar 4, 2025

Add AlloyDB language connector capabilities to alloydb vector writer. This allows iam auth, connecting via instance name and mlts.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 57.74%. Comparing base (9c8a696) to head (fe65075).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...dks/python/apache_beam/ml/rag/ingestion/alloydb.py 50.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #34156      +/-   ##
============================================
- Coverage     57.75%   57.74%   -0.01%     
  Complexity     1474     1474              
============================================
  Files           995      995              
  Lines        157686   157738      +52     
  Branches       1076     1076              
============================================
+ Hits          91064    91091      +27     
- Misses        64376    64401      +25     
  Partials       2246     2246              
Flag Coverage Δ
python 81.26% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@claudevdm claudevdm force-pushed the alloy-language-connector branch from 31fda57 to 2781466 Compare March 4, 2025 21:17
@claudevdm claudevdm force-pushed the alloy-language-connector branch from 2781466 to 01ed722 Compare March 4, 2025 21:37
@claudevdm claudevdm marked this pull request as ready for review March 5, 2025 14:38
@claudevdm
Copy link
Collaborator Author

R: @damccorm

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm claudevdm requested a review from damccorm March 5, 2025 17:42
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just had one piece of minor feedback

@damccorm damccorm merged commit 0733fa5 into apache:master Mar 5, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants