Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test #34162

Merged
merged 10 commits into from
Mar 6, 2025
Merged

Fix test #34162

merged 10 commits into from
Mar 6, 2025

Conversation

claudevdm
Copy link
Collaborator

I intentionally made this test fail to be sure they are actually running, but forgot to revert the failure force.

This should fix Python PostCommit, also triggered a run.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@claudevdm
Copy link
Collaborator Author

R: @Abacn

@claudevdm claudevdm marked this pull request as ready for review March 4, 2025 15:08
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@claudevdm
Copy link
Collaborator Author

Postcommits were still failing after changing the runner to highmem22 due to apache_beam.utils.subprocess_server:subprocess_server.py:213 java.io.IOException: Insufficient number of network buffers: required 2, but only 0 available. The total number of network buffers is currently set to 2048 of 32768 bytes each. You can increase this number by setting the configuration keys 'taskmanager.memory.network.fraction', 'taskmanager.memory.network.min', and 'taskmanager.memory.network.max'

Adding flink config fixed this. I ran just the portable test suite here https://github.com/apache/beam/actions/runs/13666811744 and it succeeded.

@claudevdm
Copy link
Collaborator Author

Triggered a full postcommit at https://github.com/apache/beam/actions/runs/13667238620.

@claudevdm claudevdm requested a review from damccorm March 5, 2025 02:37
@damccorm
Copy link
Contributor

damccorm commented Mar 5, 2025

Will merge once checks complete

@claudevdm
Copy link
Collaborator Author

Looks like all the tests are passing, except Xlang Gcp Dataflow is stuck with the same symptom as #33885 (comment)

Last time I did a sync + rebase on master to get it unstuck.

@damccorm
Copy link
Contributor

damccorm commented Mar 5, 2025

Looks like all the tests are passing, except Xlang Gcp Dataflow is stuck with the same symptom as #33885 (comment)

Last time I did a sync + rebase on master to get it unstuck.

I'll cancel/restart it to see if we can get green

@claudevdm
Copy link
Collaborator Author

Looks like all the tests are passing, except Xlang Gcp Dataflow is stuck with the same symptom as #33885 (comment)
Last time I did a sync + rebase on master to get it unstuck.

I'll cancel/restart it to see if we can get green

Thanks. Not sure if it will resolve the issue though, last time if I recall you did a restart and it was still stuck, untill I rebased + force pushed. Will keep an eye on the progress to see if it gets stuck again

@claudevdm
Copy link
Collaborator Author

Looks like the tests are all green @damccorm .

@Abacn Abacn merged commit 57c644a into apache:master Mar 6, 2025
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants