Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The 14837 bug has not been fixed #15183

Open
4 tasks done
mcck opened this issue Feb 26, 2025 · 4 comments
Open
4 tasks done

[Bug] The 14837 bug has not been fixed #15183

mcck opened this issue Feb 26, 2025 · 4 comments
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage

Comments

@mcck
Copy link

mcck commented Feb 26, 2025

Pre-check

  • I am sure that all the content I provide is in English.

Search before asking

  • I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

Dubbo Java 3.3.3
dubbo-spring-boot-starter 3.3.3
jdk21

Steps to reproduce this issue

I saw in the releases that dubbo-3.3.2 resolved #14837 , but I did not see the modified code in the application.

Image

What you expected to happen

In pom.xml, we see org.apache.dubbo:dubbo:3.3.3 used org. Apache. Dubbo: Hessian lite: 4.0.3, Hesian lite has not been updated.

Anything else

Need to update Hessian lite version

Are you willing to submit a pull request to fix on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@mcck mcck added component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage labels Feb 26, 2025
@AlbumenJ
Copy link
Member

Fix in dubbo-serialization/dubbo-serialization-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2SerializerFactory.java

@mcck
Copy link
Author

mcck commented Feb 27, 2025

Fix in dubbo-serialization/dubbo-serialization-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2SerializerFactory.java

Need to merge dubbo-hessian-lite #76 and release dubbo-hessian-lite version

@AlbumenJ
Copy link
Member

I still remember I have tested on #14837 and it worked

@mcck
Copy link
Author

mcck commented Feb 28, 2025

In Dubbo, the dubbo-hessian-lite tool is used for serialization. In the file dubbo-serialization/dubbo-serialization-hessian2/src/main/java/org/apache/dubbo/common/serialize/hessian2/Hessian2SerializerFactory.java, only this line of code was added:

if (InputStream.class.equals(cl)) {
    return InputStreamDeserializer.DESER;
}

However, the InputStreamDeserializer class is in the dubbo-hessian-lite module, and it has not been updated yet because the commits have not been merged: commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/need-triage Need maintainers to triage type/need-triage Need maintainers to triage
Projects
Status: Todo
Development

No branches or pull requests

2 participants