-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17737. Implement Backoff Retry for ErasureCoding reads #7427
Open
dannytbecker
wants to merge
4
commits into
apache:trunk
Choose a base branch
from
dannytbecker:dabecker/EC-retry-and-backoff
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HDFS-17737. Implement Backoff Retry for ErasureCoding reads #7427
dannytbecker
wants to merge
4
commits into
apache:trunk
from
dannytbecker:dabecker/EC-retry-and-backoff
+746
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Currently EC Reads are less stable than replication reads because if 4 out of 9 datanodes in the block group are unable to connect, then the whole read fails. Erasure Coding reads need to be able to handle disconnects from DataNodes and retry after a backoff duration to avoid overloading the DataNodes while increasing the stability of the read.
Throttling on server side was another proposed solution, but we prefer this client side backoff for a few main reasons:
What
The previous implementation followed a 4 phase algorithm to read.
The new implementation now merges phase 1-3 into a single loop:
faster.
Add two new states to StripingChunk:
How was this patch tested?
Add unit test to
TestWriteReadStripedFile
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?