Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YARN-11776. Handle NPE in the RMDelegationTokenIdentifier if localServiceAddress is null. #7431

Merged
merged 1 commit into from
Mar 6, 2025
Merged

YARN-11776. Handle NPE in the RMDelegationTokenIdentifier if localServiceAddress is null. #7431

merged 1 commit into from
Mar 6, 2025

Conversation

Abhey
Copy link
Contributor

@Abhey Abhey commented Feb 25, 2025 •
edited by slfan1989
Loading

Description of PR

JIRA: YARN-11776. Handle NPE in the RMDelegationTokenIdentifier if localServiceAddress is null.

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 24s trunk passed
+1 💚 compile 0m 45s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 compile 0m 41s trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 checkstyle 0m 39s trunk passed
+1 💚 mvnsite 0m 44s trunk passed
+1 💚 javadoc 0m 53s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 49s trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 1m 38s trunk passed
+1 💚 shadedclient 34m 27s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 33s the patch passed
+1 💚 compile 0m 35s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javac 0m 35s the patch passed
+1 💚 compile 0m 33s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 javac 0m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 27s the patch passed
+1 💚 mvnsite 0m 35s the patch passed
+1 💚 javadoc 0m 39s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 39s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 1m 39s the patch passed
+1 💚 shadedclient 34m 35s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 5m 56s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 36s The patch does not generate ASF License warnings.
124m 14s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7431/1/artifact/out/Dockerfile
GITHUB PR #7431
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux ccc31592e643 5.15.0-130-generic #140-Ubuntu SMP Wed Dec 18 17:59:53 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 8c75108
Default Java Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7431/1/testReport/
Max. process+thread count 566 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7431/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Abhey
Copy link
Contributor Author

Abhey commented Mar 5, 2025

@virajjasani Can you please review this PR?

@virajjasani
Copy link
Contributor

Thanks @Abhey!
This looks good, @slfan1989 could you please take a look?

@slfan1989 slfan1989 changed the title [YARN-11776] Handle NPE in the RMDelegationTokenIdentifier if localServiceAddress is null YARN-11776. Handle NPE in the RMDelegationTokenIdentifier if localServiceAddress is null. Mar 6, 2025
@slfan1989
Copy link
Contributor

@virajjasani LGTM. +1

@slfan1989 slfan1989 merged commit d7a462f into apache:trunk Mar 6, 2025
1 of 3 checks passed
@slfan1989
Copy link
Contributor

@Abhey Thanks for the contribution! @virajjasani Thanks for the review!

@Abhey
Copy link
Contributor Author

Abhey commented Mar 6, 2025

Thanks a lot @virajjasani @slfan1989 for reviewing the PR and merging it.

slfan1989 pushed a commit that referenced this pull request Mar 7, 2025
@Abhey @slfan1989
[YARN-11776] Handle NPE in the RMDelegationTokenIdentifier if localSe…
c122ff3 
…rviceAddress is null (#7431) Contributed by Abhey Rana.

Reviewed-by: Viraj Jasani <vjasani@apache.org>
Signed-off-by: Shilun Fan <slfan1989@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slfan1989 slfan1989

Assignees
No one assigned
Labels
trunk YARN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abhey @hadoop-yetus @virajjasani @slfan1989