Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): header and footer design uplift #2862

Merged

Conversation

webrdaniel
Copy link
Collaborator

No description provided.

@webrdaniel webrdaniel self-assigned this Feb 28, 2025
@webrdaniel webrdaniel added the t-web Issues with this label are in the ownership of the web team. label Mar 3, 2025
@webrdaniel webrdaniel changed the title feat: header and footer design uplift feat(website): header and footer design uplift Mar 4, 2025
Copy link
Collaborator

@baldasseva baldasseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nice for me, we can merge it to the umbrella
+
I left a comment, but preapproving for now

return (
<Link
className={clsx(styles.logoImage, 'sidebarLogo')}
to={isOnLanguageAgnosticPage ? '/' : '/javascript'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the javascript side will have /js path, Banan said

@@ -38,30 +41,84 @@ function NavbarContentLayout({
);
}

const GENERIC_PAGE_ITEMS = [{
to: 'javascript',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js

@webrdaniel webrdaniel merged commit 5e5f937 into feat/design-uplift-2025 Mar 5, 2025
1 check passed
@webrdaniel webrdaniel deleted the feat/header-and-footer-design-uplift branch March 5, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants