-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): header and footer design uplift #2862
feat(website): header and footer design uplift #2862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nice for me, we can merge it to the umbrella
+
I left a comment, but preapproving for now
website/src/theme/Logo/index.js
Outdated
return ( | ||
<Link | ||
className={clsx(styles.logoImage, 'sidebarLogo')} | ||
to={isOnLanguageAgnosticPage ? '/' : '/javascript'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the javascript side will have /js path, Banan said
@@ -38,30 +41,84 @@ function NavbarContentLayout({ | |||
); | |||
} | |||
|
|||
const GENERIC_PAGE_ITEMS = [{ | |||
to: 'javascript', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
js
No description provided.