Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): search modal design uplift #2867

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

webrdaniel
Copy link
Collaborator

No description provided.

@webrdaniel webrdaniel added the t-web Issues with this label are in the ownership of the web team. label Mar 3, 2025
@webrdaniel webrdaniel requested a review from baldasseva March 3, 2025 14:22
@webrdaniel webrdaniel self-assigned this Mar 3, 2025
@webrdaniel webrdaniel changed the title feat: search modal design uplift feat(website): search modal design uplift Mar 4, 2025
Copy link
Collaborator

@baldasseva baldasseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice

@webrdaniel webrdaniel merged commit 2c8d966 into feat/design-uplift-2025 Mar 5, 2025
1 check passed
@webrdaniel webrdaniel deleted the feat/search-modal-design-uplift branch March 5, 2025 08:07
@B4nan
Copy link
Member

B4nan commented Mar 5, 2025

one small note, please be careful with the commit types, website changes should be marked with docs, not with feat/fix, we do not want those to end up in the generated changelogs. of course it's fine when you are targeting branches other than master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants