Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The option script_stop was removed #367

Closed
fbiesse opened this issue Feb 20, 2025 · 2 comments · Fixed by #368
Closed

The option script_stop was removed #367

fbiesse opened this issue Feb 20, 2025 · 2 comments · Fixed by #368
Labels
question Further information is requested

Comments

@fbiesse
Copy link

fbiesse commented Feb 20, 2025

It is just a question:
I wonder why the option script_stop was removed without any replacement in this repository.
When I check the code of the binary which is called, I see that the option still exists on it.
This option is very convenient in case there's execution failure.

Thank you.
@appleboy
Copy link
Owner

Your understanding is correct. The script_stop option is still present in the drone-ssh executable, but it has been removed from the ssh-action settings. However, this option confused many users, so the quickest solution is to add set -e in your shell script.

@appleboy appleboy added the question Further information is requested label Feb 21, 2025
@patrickkidd
Copy link

Thanks for this answer. I also ran into this issue today and set -e works just as it does in bash proper.

Setland34 added a commit to Setland34/ssh-action that referenced this issue Feb 22, 2025
@Setland34
Update README to mention set -e for script_stop functionality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5bb32d4 
Fixes appleboy#367

Add a note in the "Input variables" section of `README.md` to mention that users can add `set -e` in their shell script to achieve similar functionality to the removed `script_stop` option.

Add a note in the "输入变量" section of `README.zh-cn.md` to mention that users can add `set -e` in their shell script to achieve similar functionality to the removed `script_stop` option.

Add a note in the "輸入變數" section of `README.zh-tw.md` to mention that users can add `set -e` in their shell script to achieve similar functionality to the removed `script_stop` option.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/appleboy/ssh-action/issues/367?shareId=XXXX-XXXX-XXXX-XXXX).
@Setland34 Setland34 mentioned this issue Feb 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(readme): set -e for script_stop functionality Setland34/ssh-action
3 participants
@appleboy @patrickkidd @fbiesse