Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3: do not rely on hostdeps python3-pip nor python3-dev; deploy pip via get-pip.py #7873

Merged
merged 1 commit into from
Feb 24, 2025
Merged

python3: do not rely on hostdeps python3-pip nor python3-dev; deploy pip via get-pip.py #7873

merged 1 commit into from
Feb 24, 2025

Conversation

rpardini
Copy link
Member

  • python3-pip implies a very old setuptools (which is system-wide and takes precedence)
  • python3-dev implies python3-distutils (which is long deprecated)
  • get-pip.py allows us to version pip in requirements.txt just like everything else
  • in the end this fixes the conundrum with pylibfdt / dtschema on Jammy
  • and, finally, the setuptools we specify in requirements.txt will be actually used

@rpardini
python3: do not rely on hostdeps python3-pip nor python3-dev; deploy …
d8d2af7 
…pip via get-pip.py

- python3-pip implies a very old setuptools (which is system-wide and takes precedence)
- python3-dev implies python3-distutils (which is long deprecated)
- get-pip.py allows us to version pip in requirements.txt just like everything else
- in the end this fixes the conundrum with pylibfdt / dtschema on Jammy
- and, finally, the setuptools we specify in requirements.txt will be actually used
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Framework Framework components labels Feb 24, 2025
@rpardini rpardini marked this pull request as ready for review February 24, 2025 03:57
@rpardini rpardini requested review from a team and igorpecovnik as code owners February 24, 2025 03:57
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 05 Milestone: Second quarter release and removed Needs review Seeking for review labels Feb 24, 2025
@igorpecovnik igorpecovnik merged commit 370f85b into armbian:main Feb 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik

Assignees
No one assigned
Labels
05 Milestone: Second quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpardini @igorpecovnik