Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rockchip64-edge: add support for yy3568 #7908

Merged
merged 9 commits into from
Mar 6, 2025
Merged

Conversation

hqnicolas
Copy link
Contributor

add support for yy3568

https://forum.armbian.com/topic/49775-board-bring-up-youyeetoo-yy3568-rockchip-rk3568/

How Has This Been Tested?

  • Youyeetoo YY3568 4GB 32GB Reference board

Checklist:

Please delete options that are not relevant.

  • [V ] My code follows the style guidelines of this project
  • [V ] I have performed a self-review of my own code
  • [V ] I have commented my code, particularly in hard-to-understand areas
  • [V ] My changes generate no new warnings
  • [V ] Any dependent changes have been merged and published in downstream modules

@hqnicolas
Copy link
Contributor Author

@amazingfate Thanks for the review, problem solved

@hqnicolas hqnicolas closed this Mar 4, 2025
@hqnicolas hqnicolas reopened this Mar 4, 2025
@hqnicolas hqnicolas requested a review from amazingfate March 4, 2025 12:01
@hqnicolas
Copy link
Contributor Author

@amazingfate Thanks for the review, file removed

@hqnicolas hqnicolas requested a review from amazingfate March 4, 2025 14:33
@hqnicolas hqnicolas requested a review from amazingfate March 4, 2025 17:35
@hqnicolas
Copy link
Contributor Author

@amazingfate Thanks for the review, boot partition removed

Copy link
Contributor

@amazingfate amazingfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the pr should use squash merge.

@hqnicolas
Copy link
Contributor Author

@paolosabatino thanks for the review, name changed

@paolosabatino paolosabatino merged commit 14b5681 into armbian:main Mar 6, 2025
8 checks passed
@hqnicolas
Copy link
Contributor Author

@amazingfate Thanks for the advice, I will squash all commits

@paolosabatino
Copy link
Contributor

I am very sorry, I did Update and Rebase without paying enough attention to the Squash and Merge suggestion by @amazingfate . Now there's a list of add support for yy3568 commits in the commits history: https://github.com/armbian/build/commits/main/. It's not a problem per-se, just a bit ugly. Maybe @igorpecovnik wants to clean that up, or leave it as-is. Sorry again for that 😞

@hqnicolas
Copy link
Contributor Author

hqnicolas commented Mar 7, 2025

@paolosabatino this is possible to solve let's wait for @igorpecovnik directives
git rebase -i HEAD~8
~keep the first as pick
~edit the second pick for squash
~edit the n pick for squash
~edit the eight pick for squash
~save and close
💀 git push --force💀

@igorpecovnik
Copy link
Member

igorpecovnik commented Mar 7, 2025

I avoid force pushing unless absolutely necessary. Is it?

P.S.
No worries Paolo ... we all did it :) Several times.

@igorpecovnik
Copy link
Member

did git push --force :)

@paolosabatino
Copy link
Contributor

paolosabatino commented Mar 7, 2025

Thanks, sorry again.

PS:
@hqnicolas
When I do such mistakes (often), I usually do:

git reset --soft <commit-id>   # Move HEAD to last good commit, also does not delete the files changed afterward, but keeps all of them in "staged for commit" status
git commit 
git push -f

to know the last good commit id, you can look into git log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

4 participants