-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend for armbian-install as a armbian-config module #384
base: main
Are you sure you want to change the base?
Conversation
9ef36ab
to
388a13d
Compare
fe980be
to
e4025f0
Compare
e4025f0
to
bac2848
Compare
|
||
function module_partitioner() { | ||
local title="Partitioner" | ||
local condition=$(which "$title" 2>/dev/null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this construction for? What does it test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am copy pasting this from template. @Tearran made this design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example, was from software title module_webmin.sh
local title="webmin"
local condition=$(which "$title" 2>/dev/null)
which (Binary name), True if NOT NULL
I am not familiar enough with docker to say for sure, assuming something like this.
# Check if a Docker container with a specific name is running
local title="my_container"
local condition=$(docker ps --filter "name=$container_name" --format "{{.Names}}" | grep "^$container_name$")
check)
if [ -n "$condition" ]; then
echo "Container $container_name is running."
else
echo "Container $container_name is not running."
fi
;;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes sense to check webmin in the system, but then it doesn't make sense to check Partitioner in the system)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then it doesn't make sense to check Partitioner in the system
(My) code sometimes makes no sense. Sorry. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't worry. i was just trying to figure out a new set of scripts)
Description
Starting partitioner to which we will attach install functions. This is at POC level, design is unfinished, just few helper functions ATM.
Refference: AR-2598
Implementation Details
For now front-end design only.
Documentation Summary
Testing Procedure
sudo bash module_partitioner.sh run
Checklist