kernel: show rk3588 vendor kernel overlays in overlays section #446
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efectn
commented
Feb 17, 2025
| @@ -35,6 +35,23 @@ function manage_dtoverlays () { | |||
| else | |||
| available_overlays=$(ls -1 ${overlaydir}/${overlay_prefix}*.dtbo | sed 's/^.*\('${overlay_prefix}'.*\)/\1/g' | sed 's/'${overlay_prefix}'-//g' | sed 's/.dtbo//g') | |||
| fi | |||
|
|
|||
| # Check the branch in case it is not available in /etc/armbian-release | |||
| if [[ -z "${BRANCH}" ]]; then | |||
There was a problem hiding this comment.
Not sure about here. I've copied these codes from other part because i realized that BRANCH is not exists on /etc/armbian-release
There was a problem hiding this comment.
Yes, we determine BRANCH at boot time script. When kernel is changing via armbian-config, this might not be the case. Needs to be investigated.
There was a problem hiding this comment.
Move this part to tools/modules/functions/set_runtime_variables.sh It might be helpful for other functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show rk3588 vendor kernel overlays which don't have prefix in overlay selection section.
Issue reference:
Related documentation:
Implementation Details
Provide a detailed description of the implementation. Include the following:
Documentation Summary
Metadata Included:
Did you include the metadata (associative arrays) in the code? Ensure that metadata for modules, jobs, and runtime has been updated appropriately.
Document Generated:
Did you generate the updated documentation using
armbian-configng --doc? Confirm if the command was run to updateREADME.mdand provide any relevant details.Testing Procedure
Describe the tests you ran to verify your changes. Provide relevant details about your test configuration.
Checklist