Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zerotier software #453

Closed
wants to merge 5 commits into from
Closed

Add Zerotier software #453

wants to merge 5 commits into from

Conversation

jnovos
Copy link

@jnovos jnovos commented Feb 19, 2025

Description

Add Zerotier to software option menu.

Issue reference:
Related documentation: https://docs.zerotier.com/wat)

Implementation Details

Provide a detailed description of the implementation. Include the following:

  • Key changes introduced by this PR
  • Justification for the changes
  • Confirmation that no new external dependencies or modules have been introduced

Documentation Summary

  • Metadata Included:
    Did you include the metadata (associative arrays) in the code? Ensure that metadata for modules, jobs, and runtime has been updated appropriately.

  • [x ] Document Generated:
    Did you generate the updated documentation using armbian-configng --doc? Confirm if the command was run to update README.md and provide any relevant details.

Testing Procedure

Describe the tests you ran to verify your changes. Provide relevant details about your test configuration.

  • [x ] Test 1: Description and results
  • Test 2: Description and results

Checklist

  • [x ] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • [x ] No new external dependencies are included
  • [x ] Changes have been tested and verified
  • [x ] I have included necessary metadata in the code, including associative arrays

Add all functionally
Add a new section into software with name VPN and add Zerotier
Add new module Zerotier
@github-actions github-actions bot added Documentation Documentation changes or additions Unit Tests size/medium PR with more then 50 and less then 250 lines labels Feb 19, 2025
@EvilOlaf
Copy link
Member

There seem to be a lot of unrelated changes to DOCUMENTATION.md?

@igorpecovnik
Copy link
Member

There seem to be a lot of unrelated changes to DOCUMENTATION.md?

Documentation should be excluded from commit - it is generated automatically.

@jnovos
Copy link
Author

jnovos commented Feb 20, 2025

There seem to be a lot of unrelated changes to DOCUMENTATION.md?

Documentation should be excluded from commit - it is generated automatically.

Hi ,
do i have to modify the pull rquest?

Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And exclude changes in DOCUMENTATION.md

@jnovos jnovos closed this Mar 5, 2025
@jnovos jnovos deleted the Zerotier branch March 5, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation changes or additions size/medium PR with more then 50 and less then 250 lines Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants