Skip to content

Commit 940baa2

Browse files
authoredMar 7, 2025
Add loading icon to summary panel (#166)
* hiding author approval * adding loading icon to summary changes
1 parent 5bb465b commit 940baa2

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed
 

‎src/react/atlascode/pullrequest/PullRequestDetailsPage.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ export const PullRequestDetailsPage: React.FunctionComponent = () => {
213213
rawSummary={state.pr.data.rawSummary}
214214
htmlSummary={state.pr.data.htmlSummary}
215215
fetchUsers={handleFetchUsers}
216+
isLoading={state.loadState.basicData}
216217
summaryChange={controller.updateSummary}
217218
/>
218219
</Grid>

‎src/react/atlascode/pullrequest/SummaryPanel.tsx

+13-8
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ExpansionPanel, ExpansionPanelDetails, ExpansionPanelSummary } from '@material-ui/core';
1+
import { ExpansionPanel, ExpansionPanelDetails, ExpansionPanelSummary, CircularProgress } from '@material-ui/core';
22
import ExpandMoreIcon from '@material-ui/icons/ExpandMore';
33
import React, { memo, useCallback, useState } from 'react';
44
import { User } from '../../../bitbucket/model';
@@ -9,10 +9,11 @@ type SummaryPanelProps = {
99
htmlSummary: string;
1010
fetchUsers: (input: string) => Promise<User[]>;
1111
summaryChange: (text: string) => void;
12+
isLoading: boolean;
1213
};
1314

1415
export const SummaryPanel: React.FunctionComponent<SummaryPanelProps> = memo(
15-
({ rawSummary, htmlSummary, fetchUsers, summaryChange }) => {
16+
({ rawSummary, htmlSummary, fetchUsers, summaryChange, isLoading }) => {
1617
const [internalExpanded, setInternalExpanded] = useState(true);
1718

1819
const expansionHandler = useCallback((event: React.ChangeEvent<{}>, expanded: boolean) => {
@@ -39,12 +40,16 @@ export const SummaryPanel: React.FunctionComponent<SummaryPanelProps> = memo(
3940
<PanelTitle>Summary</PanelTitle>
4041
</ExpansionPanelSummary>
4142
<ExpansionPanelDetails>
42-
<InlineRenderedTextEditor
43-
rawContent={rawSummary}
44-
htmlContent={htmlSummary}
45-
onSave={handleSummaryChange}
46-
fetchUsers={handleFetchUsers}
47-
/>
43+
{isLoading ? (
44+
<CircularProgress />
45+
) : (
46+
<InlineRenderedTextEditor
47+
rawContent={rawSummary}
48+
htmlContent={htmlSummary}
49+
onSave={handleSummaryChange}
50+
fetchUsers={handleFetchUsers}
51+
/>
52+
)}
4853
</ExpansionPanelDetails>
4954
</ExpansionPanel>
5055
);

0 commit comments

Comments
 (0)
Failed to load comments.