Skip to content

Commit c3e69cc

Browse files
committedMar 6, 2025
AXON-201: fixes
1 parent 0f8b472 commit c3e69cc

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed
 

‎src/react/atlascode/onboarding/OnboardingPage.tsx

+7-8
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import ProductSelector from './ProductSelector';
1616
import { SimpleSiteAuthenticator } from './SimpleSiteAuthenticator';
1717
import { AtlascodeErrorBoundary } from '../common/ErrorBoundary';
1818
import { AnalyticsView } from '../../../analyticsTypes';
19-
import { Experiments, Features } from '../../../util/featureFlags';
19+
import { Experiments } from '../../../util/featureFlags';
2020
import { CommonMessageType } from '../../../lib/ipc/toUI/common';
2121
import { OnboardingActionType } from '../../../lib/ipc/fromUI/onboarding';
2222
import { JiraOnboarding } from './JiraOnboarding';
@@ -60,7 +60,7 @@ export const OnboardingPage: React.FunctionComponent = () => {
6060
const [state, controller] = useOnboardingController();
6161
const { authDialogController, authDialogOpen, authDialogProduct, authDialogEntry } = useAuthDialog();
6262
const [activeStep, setActiveStep] = React.useState(0);
63-
const [authExpEnabled, setAuthExpEnabled] = React.useState(false);
63+
// const [authExpEnabled, setAuthExpEnabled] = React.useState(false);
6464
const [useAuthUI, setUseAuthUI] = React.useState(false);
6565
const [jiraSignInText, setJiraSignInText] = useState('Sign In to Jira Cloud');
6666
const [bitbucketSignInText, setBitbucketSignInText] = useState('Sign In to Bitbucket Cloud');
@@ -70,15 +70,14 @@ export const OnboardingPage: React.FunctionComponent = () => {
7070
React.useEffect(() => {
7171
window.addEventListener('message', (event) => {
7272
const message = event.data;
73-
if (message.command === CommonMessageType.UpdateFeatureFlags) {
74-
const featureValue = message.featureFlags[Features.EnableAuthUI];
75-
setAuthExpEnabled(featureValue);
76-
} else if (message.command === CommonMessageType.UpdateExperimentValues) {
73+
if (message.command === CommonMessageType.UpdateExperimentValues) {
7774
const experimentValue = message.experimentValues[Experiments.NewAuthUI];
78-
setUseAuthUI(authExpEnabled && experimentValue === 'new');
75+
if (typeof experimentValue === 'string' && experimentValue !== undefined && experimentValue !== null) {
76+
setUseAuthUI(experimentValue === 'new');
77+
}
7978
}
8079
});
81-
}, [authExpEnabled, controller]);
80+
}, [controller]);
8281
function getSteps() {
8382
if (useAuthUI) {
8483
return ['Setup Jira', 'Setup BitBucket', 'Explore'];

0 commit comments

Comments
 (0)
Failed to load comments.