Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AXON-149] (WIP) re-enable auth UI for bitbucket in RDE #146

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

sdzh-atlassian
Copy link
Member

@sdzh-atlassian sdzh-atlassian commented Feb 24, 2025

What is this?

⚠️ Note: found some issues while submitting the PR - hence draft

  • url parsing might be borked after rebase, somehow - tested, works now
  • would be good to disable the save button in BB cloud - maybe in a follow-up
  • Please note that this specifically DOESN'T address BB cloud auth, and targets BasicAuth/PAT on BB DC/server instead

This PR enables the custom auth flow for Bitbucket in RDE, in the same way as JIRA - except using BB app password turned out to be a really poor substitute for JIRA API token, so that's not available ;)

The rationale here is to enable folks who use BB Server/DC to authenticate remotely from RDEs via PAT/basic auth

Old New
Local
(no change)
image image
Remote image image

UI after this:
image

How was this tested?

  • Via dev-container, managed to authenticate against an available instance of BB DC

@sdzh-atlassian sdzh-atlassian force-pushed the AXON-149-enable-remote-auth-bitbucket branch from fa04722 to 72ef5da Compare February 24, 2025 19:56
@sdzh-atlassian sdzh-atlassian force-pushed the AXON-149-enable-remote-auth-bitbucket branch from 72ef5da to 89a04bd Compare February 24, 2025 19:57
@livingtonds
Copy link

Hi!What about plans for merging this pr?)

@sdzh-atlassian
Copy link
Member Author

Hi folks!

url parsing might be borked after rebase, somehow
Sorry about the delay with this, the error above was caused by an incident we had last week - but back then we weren't sure and put this on pause :)

I'm updating and re-submitting it for approval

@sdzh-atlassian
Copy link
Member Author

Just tested the urtl parser - everything seems to be in order.

Please note that this PR DOES NOT address the cloud auth not working in RDE - but should at least allow basic/PAT auth against BB DC/server

@sdzh-atlassian sdzh-atlassian marked this pull request as ready for review March 3, 2025 22:56
@sdzh-atlassian sdzh-atlassian merged commit 82d6eab into main Mar 3, 2025
2 checks passed
@sdzh-atlassian sdzh-atlassian deleted the AXON-149-enable-remote-auth-bitbucket branch March 3, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants