Axon 137 sidebar UI new sidebar view for jq ls #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabella-dot
commented
Feb 28, 2025
cabella-dot
requested review from
bwieger-atlassian-com,
sdzh-atlassian and
marcomura
as code owners
marcomura
reviewed
Feb 28, 2025
marcomura
reviewed
Feb 28, 2025
marcomura
previously approved these changes
Mar 4, 2025
cabella-dot
force-pushed
the
AXON-137-sidebar-ui-new-sidebar-view-for-jq-ls
branch
from
97904c9 to
24f4c60
Compare
marcomura
previously approved these changes
Mar 4, 2025
sdzh-atlassian
previously approved these changes
Mar 4, 2025
bwieger-atlassian-com
requested changes
Mar 4, 2025
…mjqlviewprovider merge
cabella-dot
force-pushed
the
AXON-137-sidebar-ui-new-sidebar-view-for-jq-ls
branch
from
24f4c60 to
eab13a7
Compare
|
@cabella-dot Reviewed! LGTM Here's my review video: https://www.loom.com/share/7045725bcdfd4ffc8b5e78cbf7d677f6?sid=bb5ed99c-8a20-418d-9e5a-cd654025e69c It looks like you resolved one of the JQL bugs with this PR. Good work! 🚀 There is still an outstanding pre-existing bug. But not an expectation to solve in this PR. |
bwieger-atlassian-com
approved these changes
Mar 4, 2025
bwieger-atlassian-com
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
https://www.loom.com/share/6cd9a9ec8fd14dbdbe7aa78966ab4b69