Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading state for "Checkout Source Branch" button #161

Conversation

mkenchugonde
Copy link
Contributor

@mkenchugonde mkenchugonde commented Mar 3, 2025

Customer Problem

The 'Checkout source Branch' button in the Pull Request view doesn't have a loading state, and it gives the impression that nothing is happening, and suddenly, it changes to 'Source branch Checkout out.'

This PR will add a loading state to the 'Checkout source Branch' button, which will help to ensure that the checkout is in progress instead of clicking the button multiple times.

Loom Video: https://www.loom.com/share/c58dda9fb5bd494f979cbd940a955f6a?sid=43894cfe-7c32-4438-ad13-cbabec5ec227

Copy link

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution.
If your email is listed below, please ensure that you sign the CLA with the same email address.

The following users still need to sign our CLA:
❌mkenchugonde

Already signed the CLA? To re-check, try refreshing the page.

@sdzh-atlassian
Copy link
Member

sdzh-atlassian commented Mar 4, 2025

Hi @mkenchugonde! Thanks for the PR :)

I'm assuming you're a colleague; not sure why it's complaining about the CLA issue - but it's most likely because you're not part of atlassian github org 🤔

IIRC there's a self-serve way of linking your account outlined in Confluence - but if that doesn't help, please feel free to hit me up on Slack, or raise it with #opensource

Copy link
Member

@sdzh-atlassian sdzh-atlassian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! ;)

@pastelsky pastelsky self-requested a review March 4, 2025 03:20
Copy link
Collaborator

@bwieger-atlassian-com bwieger-atlassian-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

For all PRs, could you help us by:

  1. Visual demostrating the change (loom video / before-after pictures)
  2. Lining this up to a customer problem

@mkenchugonde
Copy link
Contributor Author

Hi,

For all PRs, could you help us by:

  1. Visual demostrating the change (loom video / before-after pictures)
  2. Lining this up to a customer problem

Hi @bwieger-atlassian-com I have updated the PR description. Thanks for the review.

Copy link
Collaborator

@bwieger-atlassian-com bwieger-atlassian-com left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkenchugonde mkenchugonde merged commit 172e307 into atlassian:main Mar 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants