-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading state for "Checkout Source Branch" button #161
Loading state for "Checkout Source Branch" button #161
Conversation
Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution. Already signed the CLA? To re-check, try refreshing the page. |
Hi @mkenchugonde! Thanks for the PR :) I'm assuming you're a colleague; not sure why it's complaining about the CLA issue - but it's most likely because you're not part of IIRC there's a self-serve way of linking your account outlined in Confluence - but if that doesn't help, please feel free to hit me up on Slack, or raise it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
For all PRs, could you help us by:
- Visual demostrating the change (loom video / before-after pictures)
- Lining this up to a customer problem
Hi @bwieger-atlassian-com I have updated the PR description. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
FYI (No Action Required): My UX review in a loom: https://www.loom.com/share/6f8b427f9cbb4014a3a7fe1d34af3a34?sid=6ac8adc1-47a5-4fc1-887d-1c88e0010130
Customer Problem
The 'Checkout source Branch' button in the Pull Request view doesn't have a loading state, and it gives the impression that nothing is happening, and suddenly, it changes to 'Source branch Checkout out.'
This PR will add a loading state to the 'Checkout source Branch' button, which will help to ensure that the checkout is in progress instead of clicking the button multiple times.
Loom Video: https://www.loom.com/share/c58dda9fb5bd494f979cbd940a955f6a?sid=43894cfe-7c32-4438-ad13-cbabec5ec227