Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions due to failures in FeatureFlagClient initialization #164

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

marcomura
Copy link
Contributor

The code was throwing exceptions because when failing to retrieve the data from the server (e.g., missing .env file), the fields FeatureFlagClient._featureGates and FeatureFlagClient._experimentValues were left uninitialized.

sdzh-atlassian
sdzh-atlassian previously approved these changes Mar 3, 2025
cabella-dot
cabella-dot previously approved these changes Mar 3, 2025
Copy link
Contributor

@cabella-dot cabella-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcomura marcomura dismissed stale reviews from cabella-dot and sdzh-atlassian via ad0819a March 3, 2025 23:58
@marcomura marcomura merged commit 2e6bbd3 into main Mar 4, 2025
2 checks passed
@marcomura marcomura deleted the fix-error-fetching-ffGates branch March 4, 2025 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants