Revert "[AXON-17] (WIP) fix weird site list behaviour" #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 94a4c7b.
sdzh-atlassian
requested review from
bwieger-atlassian-com,
cabella-dot and
marcomura
as code owners
cabella-dot
approved these changes
Mar 5, 2025
marcomura
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This is a PR where we revert the change in how site information is stored (credential ID vs credential ID+extra info). See original PR for a before-and-after
We suspect this change might have been causing friction in the auth experience. The exact root cause is pending confirmation, but we've decided to roll this back anyway to err on the side of caution moving forward
How was this tested?
Compiled the extension, did a couple rounds of authentication, poked around with JIRA functionality