Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display name #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gokaygurcan
Copy link

Hi,

Atlassian API returns something like this:

{
    "self": "",
    "accountId": "",
    "emailAddress": "",
    "avatarUrls": {
        "48x48": "",
        "24x24": "",
        "16x16": "",
        "32x32": ""
    },
    "displayName": "",
    "active": true,
    "timeZone": "",
    "locale": "",
    "groups": {
        "size": 0,
        "items": []
    },
    "applicationRoles": {
        "size": 0,
        "items": []
    },
    "expand": "groups,applicationRoles"
}

That's why, we keep seeing a weird message in GitHub Actions logs like:

Logged in as: undefined

This change is to fix that problem, and to display correct name value.

Best,
G.

@gokaygurcan
Copy link
Author

hello?

@gokaygurcan
Copy link
Author

Hi @thombergs,

(At the time i was typing this message, you were the last committer to github-for-jira repository. That's the only reason why I'm pinging you and not someone else)

Can you please confirm that this repository is dead? There's no activity since 2019 and there're open PRs to fix some broken things and no one cares about those. If the repo is dead, I think we deserve to know it so that we can move on and do it in our way instead of depending on this official solution. Which is not your priority anyway from the looks of it.

I hope this makes sense.

Best,
G.

@thombergs
Copy link

Hey @gokaygurcan,

let's ask @drudzikatlassian , @rudzon , @swinton, since they are listed as contributors for this repository.

Funny that you tag me, though, because my team will be taking up some work with GitHub Actions for Jira (probably early 2022) and I didn't know about this repository. I'll bring it up with the team so that we may discuss taking ownership of this repo earlier to review PRs and stuff. I'll have a look through the repo next week!

@gokaygurcan
Copy link
Author

Thanks big time!

@gokaygurcan gokaygurcan mentioned this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants