Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

michael-letcher
Copy link

Had to add a favicon, seeing the tab without just didn't feel right 😆

Copy link

atlassian-cla-bot bot commented Feb 7, 2024

Hooray! All contributors have signed the CLA.

@BeginArjun
Copy link

Hey michael,
Shouldn't we be using a .ico file for favicons? Also I think we do have a .svg file which can be used since it is also preferred instead of .png

@michael-letcher
Copy link
Author

Hey @BeginArjun should we be using an Ico? Doesn't really matter these days.

Yes the SVG would be better, but I don't know what the URL for that asset it. So in the mean time we should get this change in and if you want to change it to the SVG or add icon that could be good.

@BeginArjun
Copy link

Hey @BeginArjun should we be using an Ico? Doesn't really matter these days.

Yes the SVG would be better, but I don't know what the URL for that asset it. So in the mean time we should get this change in and if you want to change it to the SVG or add icon that could be good.

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants