Made Msi Version Converter OS agnostic and Reversible #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Description of changes
Note
Full tag history is required for reverse lookup since the original integer division conversion for MSI versions cannot be mathematically reversed
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
I ran the following commands to test it:
go run msiversionconverter.go 1.300052.0 ../amazon-cloudwatch-agent.wxs '<version>'
Output:
amazon-cloudwatch-agent.wxs:
go run msiversionconverter.go --reverse 1.4.37908
go run msiversionconverter.go 1.300052.1024