-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate kms key #1567
base: main-opsathon
Are you sure you want to change the base?
Associate kms key #1567
Conversation
@@ -1,7 +1,7 @@ | |||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
// SPDX-License-Identifier: MIT | |||
|
|||
package collect_list | |||
package collectlist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to change package name due to lint issues
3c62e3d
to
1caa3f0
Compare
c53d22c
to
4cd2208
Compare
ab8e831
to
285f71c
Compare
@@ -77,7 +77,7 @@ func TestCreateDestination(t *testing.T) { | |||
pusherStopChan: make(chan struct{}), | |||
cwDests: make(map[pusher.Target]*cwDest), | |||
} | |||
dest := c.CreateDest(testCase.cfgLogGroup, testCase.cfgLogStream, testCase.cfgLogRetention, testCase.cfgLogClass, testCase.cfgTailerSrc).(*cwDest) | |||
dest := c.CreateDest(testCase.cfgLogGroup, testCase.cfgLogStream, "", testCase.cfgLogRetention, testCase.cfgLogClass, testCase.cfgTailerSrc).(*cwDest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a unit test when kms id is not empty and validate the dest
for the key
This PR was marked stale due to lack of activity. |
Description of the issue
Currently customer can not pass in kms key id in for log group to assoicate their log groups to there kms key. This pr allow customer to pass in kms_key_id for there log groups.
Example agent config:
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ran test to check if there is not kms key or if kms key is wrong or if api request fails and make sure we fails safely and don't panic. Also tested and log group creation works (log groups have kms key id assoicated with them)
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint