Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(core): add tag parameter to BundlingDockerImage.from_asset to tag the docker image and keep it cached #11936

Open
2 tasks
TheEdgeOfRage opened this issue Dec 8, 2020 · 3 comments
Open
2 tasks

(core): add tag parameter to BundlingDockerImage.from_asset to tag the docker image and keep it cached #11936

TheEdgeOfRage opened this issue Dec 8, 2020 · 3 comments
Labels
@aws-cdk/core Related to core CDK functionality effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@TheEdgeOfRage
Copy link

It would be nice if the from_asset method in BundlingDockerImage could accept a tag (or similar) parameter and use that to tag the docker image that it's building.

Use Case

Currently, the output image is completely untagged, which leads to it getting deleted whenever I run docker image prune and then CDK has to rebuild it from scratch the next time I run deploy.

Proposed Solution

If CDK tags the image, it will keep the latest version (or all if the tag changes) saved locally to act as a build cache for future builds, saving on build time.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@TheEdgeOfRage TheEdgeOfRage added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 8, 2020
@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Dec 8, 2020
@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p2 labels Dec 8, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Dec 8, 2020
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@TRANTANKHOA
Copy link

may be related to this

@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 29, 2022
@TRANTANKHOA
Copy link

cdk deployment is very slow without this feature. Please let this open

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/core Related to core CDK functionality effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rix0rrr @TRANTANKHOA @SomayaB @TheEdgeOfRage