Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cdk): Add Dockerfile #1569

Merged
merged 2 commits into from
Jan 23, 2019
Merged

feat(cdk): Add Dockerfile #1569

merged 2 commits into from
Jan 23, 2019
+46 −1

Conversation

jonathanmorley
Copy link
Contributor

@jonathanmorley jonathanmorley commented Jan 18, 2019 •
edited
Loading

fixes #1302

This PR should be followed up with a Dockerhub automated build configured to build from git tags

Pull Request Checklist

  • Testing
    • Unit test added
    • CLI change?: manually run integration tests and paste output as a PR comment
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Sorry, something went wrong.

@jonathanmorley jonathanmorley requested a review from a team as a code owner January 18, 2019 00:30
@sam-goodwin sam-goodwin added the feature-request A feature should be added or improved. label Jan 18, 2019
eladb
eladb approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some more context (and probably document in the contributing guide) what use case does it serve and how to use it?

@jonathanmorley
Copy link
Contributor Author

The use-cases are mainly around using the CDK in environments where running tools in docker is preferred over installing and running through npm. This gives an easier and more official way to run the CDK in that way.

As examples of this there are a number of CI platforms that either have first-class support (e.g. Jenkins pipelines), or only support (e.g. GitHub Actions), for running via a docker image.

@sam-goodwin sam-goodwin added the package/tools Related to AWS CDK Tools or CLI label Jan 18, 2019
@Doug-AWS
Copy link
Contributor

This is a great addition to the CDK. I'll add a blurb in the guide once we merge, and make it public once it's in a release.

@sam-goodwin sam-goodwin removed the feature-request A feature should be added or improved. label Jan 22, 2019
@rix0rrr rix0rrr merged commit f997fd2 into aws:master Jan 23, 2019
RomainMuller
RomainMuller reviewed Jan 23, 2019
View reviewed changes
Dockerfile
git \
rsync \
zip \
python3 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we need python3 for? o_O

Copy link
Contributor Author

@jonathanmorley jonathanmorley Jan 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used during testing, see https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-s3-deployment/lambda/test.sh#L19-L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller

@eladb eladb

Assignees
No one assigned
Labels
package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish public Docker image containing the CDK CLI
6 participants
@jonathanmorley @Doug-AWS @RomainMuller @eladb @rix0rrr @sam-goodwin