fix(s3-deployment): Add retry/backoff to create invalidation #25502
Conversation
|
|
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
We have been experiencing this issue often enough that it became too disruptive and we had to implement a fix outside our CI/CD pipeline.
This fix doesn't handle the issue where the waiter timeouts after ten minutes, but the issue where the 'CreateInvalidation' API call returns a 503 immediately. That was the issue we've been experiencing most often.
I wasn't sure how to write a useful unit test but I'm currently trying to reproduce the issue in an integration test so that I can be sure its handled properly.
Any feedback is appreciated.
Closes #15891.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license