fix(s3): expiredObjectDeleteMarker is not validated against other properties #23974
+67
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aws-cdk-automation
previously requested changes
Feb 2, 2023
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
otaviomacedo
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
TheRealAmazonKendra
requested changes
Feb 9, 2023
Comment on lines
+2025
to
+2028
| if ((rule.expirationDate || rule.expiration || rule.tagFilters) && rule.expiredObjectDeleteMarker) { | ||
| throw new Error('expiredObjectDeleteMarker cannot be true if expirationDate, expiration, or tagFilters are specified'); | ||
| } | ||
|
|
There was a problem hiding this comment.
This seems like we need a contract refactor and potential deprecation of props instead of throwing this error. Thoughts?
There was a problem hiding this comment.
Yes, there is a combinatorial explosion here caused by all these properties working together. I can't even think of a different contract that puts all these together in a coherent way. But I'm open to suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the validation documented for the resource property
ExpiredObjectDeleteMarkerCloses #18924.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license