Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(cli): Update TemplateDiff to include nested TemplateDiffs #19162

Open
comcalvi opened this issue Feb 25, 2022 · 0 comments
Open

(cli): Update TemplateDiff to include nested TemplateDiffs #19162

comcalvi opened this issue Feb 25, 2022 · 0 comments
Labels
effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@comcalvi
Copy link
Contributor

comcalvi commented Feb 25, 2022 •
edited by skinny85
Loading

Nested Stack handling in the CLI would benefit from a change to TemplateDiff

Both the nested stacks diff output and the hotswapping support for resources in nested stacks would benefit from a modification to TemplateDiff. Nested stacks should contain their own TemplateDiff, as this would prevent us from recalculating it during hotswapping and it would give us greater control over the diff output of nested stacks.
@comcalvi comcalvi added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2022
@comcalvi comcalvi self-assigned this Feb 25, 2022
@comcalvi comcalvi added the effort/medium Medium work item – several days of effort label Feb 25, 2022
@comcalvi comcalvi mentioned this issue Feb 25, 2022
Merged
@skinny85 skinny85 added p1 feature-request A feature should be added or improved. feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2022
@comcalvi comcalvi added p2 and removed p1 labels Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@skinny85 @NGL321 @ryparker @peterwoodworth @comcalvi