Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ec2): Expose instance properties on InstanceType #12022

Open
christophercarney opened this issue Dec 11, 2020 · 4 comments · May be fixed by #29507
Open

(aws-ec2): Expose instance properties on InstanceType #12022

christophercarney opened this issue Dec 11, 2020 · 4 comments · May be fixed by #29507
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p2

Comments

@christophercarney
Copy link

christophercarney commented Dec 11, 2020 •
edited
Loading

There are many supporting properties unique to EC2 InstanceType. Some AWS supporting services are conditioned on these properties so they should be readily available to developers in the framework.

Use Case

The specific usecase I have in mind is Cloudwatch monitoring of SageMaker endpoints, from there:

CPUUtilization: The percentage of CPU units that are used by the containers on an instance. The value can range between 0 and 100, and is multiplied by the number of CPUs. For example, if there are four CPUs, CPUUtilization can range from 0% to 400%

This requires the manual process of looking up the relevant information for your current instance type on the web and hard-coding it in the CDK if you want to properly condition Cloudwatch alarms on these metrics. An ideal CX would be one where the developer doesn't need to leave CDK to get the information required.

Proposed Solution

There could be some static mapping or interface of various instance properties which are keyed on InstanceType. As a first step some of the properties from https://aws.amazon.com/ec2/instance-types/ could be incorporated with the intent to expand to all types + properties in the future.

This is a 🚀 Feature Request
@christophercarney christophercarney added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2020
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 11, 2020
@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p2 labels Dec 14, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 14, 2020

Potentially a prayer without an end (as we say in Dutch) to keep up with the new instance types, but might make for a nice additional validation.

Unlikely to be picked up by core team, but an enterprising contributor might add it. The system should be prepared to fail open given insufficient information though.

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Dec 14, 2020
@ericzbeard ericzbeard added the feature/service-integration Add functionality to an L2 construct to enable easier integration with another service label Apr 2, 2021
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 3, 2022
@kylehoxi
Copy link

kylehoxi commented Jun 8, 2022

I have a use case for this as well. Please leave open.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jun 8, 2022
@nmussy
Copy link
Contributor

nmussy commented Mar 11, 2024

I can take this on, I won't make it a priority but I already have the necessary tools to create these properties

This was referenced Mar 12, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ec2): instance type properties nmussy/aws-cdk
6 participants
@rix0rrr @ericzbeard @nmussy @christophercarney @SomayaB @kylehoxi