Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): allow to specify availability zone for Aurora instances #33515

Merged
merged 9 commits into from
Mar 12, 2025
Merged

feat(rds): allow to specify availability zone for Aurora instances #33515

merged 9 commits into from
Mar 12, 2025
+37,279 −0

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Feb 20, 2025 •
edited
Loading

Issue # (if applicable)

Closes #33503.
Closes #30618.

Reason for this change

When creating a single-zone Aurora cluster and an EC2 instance in development purpose, I want to pin the Aurora instance and the EC2 instance in a same availability zone.
We can specify AvailabilityZone in Aurora's AWS::RDS::DBInstance as same as standalone RDS instances.

Description of changes

Added availabilityZone prop in ClusterInstanceOptions

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Unit test and integ test.
The integ test also verifies created instances are placed in expected availability zone.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

@Tietew
add availabilityZone for aurora instances

Verified

This commit was signed with the committer’s verified signature.
connor4312 Connor Peet
GPG key ID: CF8FD2EA0DBC61BD
Verified
Learn about vigilant mode
Loading
Loading status checks…
a757c59
@aws-cdk-automation aws-cdk-automation requested a review from a team February 20, 2025 04:05
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Feb 20, 2025
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Tietew

This comment was marked as resolved.

Sign in to view
@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 20, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (4886a3e) to head (7027114).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33515   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files         120      120           
  Lines        6937     6937           
  Branches     1170     1170           
=======================================
  Hits         5715     5715           
  Misses       1119     1119           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 20, 2025
@github-actions github-actions bot mentioned this pull request Mar 1, 2025
Open
@Leo10Gama Leo10Gama self-assigned this Mar 11, 2025
Leo10Gama
Leo10Gama previously requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Just one small nit that I think would make the integration test a little more readable for the future.

With respect to the README changes, we should include an example of the new property to showcase how it's expected to be used. Please include it either in a new section in the README, or in one of the existing examples. Thank you!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 11, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 12, 2025 06:33

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed Leo10Gama’s stale review March 12, 2025 07:04

Pull request has been modified.

@Tietew
Copy link
Contributor Author

Tietew commented Mar 12, 2025

@Leo10Gama
Thanks for your review! I've updated tests and README.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 12, 2025
@Leo10Gama Leo10Gama removed the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 12, 2025
Leo10Gama
Leo10Gama approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@Leo10Gama Leo10Gama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, changes LGTM! Thanks again for your contribution!

@Leo10Gama
Copy link
Member

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

update

✅ Branch has been successfully updated

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7027114
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 12, 2025
@mergify mergify bot merged commit 583d5f2 into aws:main Mar 12, 2025
23 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2025
@Tietew Tietew deleted the rds-aurora-pin-az branch March 12, 2025 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Leo10Gama Leo10Gama

@aws-cdk-automation aws-cdk-automation

Assignees

@Leo10Gama Leo10Gama

Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
3 participants
@Tietew @Leo10Gama @aws-cdk-automation