Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rds): monitoringInterval in DatabaseClusterProps does not work with token #33516

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix(rds): monitoringInterval in DatabaseClusterProps does not work with token #33516

merged 2 commits into from
Feb 21, 2025
+29 −1

Conversation

Tietew
Copy link
Contributor

@Tietew Tietew commented Feb 20, 2025

Issue # (if applicable)

Closes #33504.

Reason for this change

monitoringInterval prop in DatabaseClusterProps should accept a token.

Description of changes

Skip validations if monitoringInterval is a token.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added a unit test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Sorry, something went wrong.

@Tietew
allow token for monitoringInterval

Verified

This commit was signed with the committer’s verified signature.
connor4312 Connor Peet
GPG key ID: CF8FD2EA0DBC61BD
Verified
Learn about vigilant mode
Loading
Loading status checks…
8336725
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Feb 20, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team February 20, 2025 04:33
aws-cdk-automation
aws-cdk-automation previously requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@Tietew Tietew changed the title allow token for monitoringInterval in DatabaseClusterProps fix(rds): allow token for monitoringInterval in DatabaseClusterProps Feb 20, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (3b07346) to head (37b1fe9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #33516   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5639     5639           
  Misses       1120     1120           
  Partials      103      103
Flag Coverage Δ
suite.unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk ∅ <ø> (∅)
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@Tietew
Copy link
Contributor Author

Tietew commented Feb 20, 2025

Exemption Request

This PR changes validations only.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 20, 2025
go-to-k
go-to-k approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@go-to-k go-to-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I will approve. But could you please change the PR title to the style: fix(rds): description of the bug in the fix case?

For example: fix(rds): `monitoringInterval` in `DatabaseClusterProps` does not work with token.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 21, 2025
@Tietew Tietew changed the title fix(rds): allow token for monitoringInterval in DatabaseClusterProps fix(rds): fix(rds): monitoringInterval in DatabaseClusterProps does not work with token Feb 21, 2025
@Tietew Tietew changed the title fix(rds): fix(rds): monitoringInterval in DatabaseClusterProps does not work with token fix(rds): monitoringInterval in DatabaseClusterProps does not work with token Feb 21, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 21, 2025
@GavinZZ
Copy link
Contributor

GavinZZ commented Feb 21, 2025

Thank you for the fix! I've approved it and let's get this released in next week's release.

@GavinZZ GavinZZ added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Feb 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 21, 2025 21:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 37b1fe9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f9b28b9 into aws:main Feb 21, 2025
19 of 20 checks passed
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025
@Tietew Tietew deleted the rds-monitoringinterval-token branch February 22, 2025 01:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@go-to-k go-to-k

@GavinZZ GavinZZ

@aws-cdk-automation aws-cdk-automation

Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_rds: DatabaseCluster is not accepting token in monitoringInterval after CDK 2.171.0
4 participants
@Tietew @GavinZZ @aws-cdk-automation @go-to-k